[Sema] Clean up comments and SmallVector capacity for derived Equatable conformance #18382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing comment references the old way to do the comparison with a state variable. Updated comment covers how the function works and matches up the parameter names too.
|
@swift-ci please smoke test and merge |
|
Merging failed, going to do it manually because tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small things:
The comment for the helper function
returnIfNotEqualGuardreferenced an older implementation. Updated to match the current implementation.The generated
guardhas a single condition and a single statement in the body. It looks like the old implementation had two statements, but thestatementssmall vector only needs room for one.