Refine The Frontend's Understanding of SwiftOnoneSupport #18410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, okay. I guess it's too late to do the implicit import by the time we reload a SIL or SIB file. |
|
Maybe just going back to |
|
@swift-ci please smoke test |
CodaFi
force-pushed
the
in-sib-id-attitudes
branch
from
80977d9 to
5e41183
Compare
Continuing work from swiftlang#18344, be more conservative about when we load SwiftOnoneSupport. Specifically, -emit-silgen and -emit-sibgen, despite not going through the SIL Optimizer, may silently introduce dependencies on SwiftOnoneSupport. Because we want to support the ability to posthumously compile SILGen and SIBGen'd files with these implicit dependencies, and because SIL is not yet capable of expressing the dependency itself, we must always assume we need to load SwiftOnoneSupport.
CodaFi
force-pushed
the
in-sib-id-attitudes
branch
from
5e41183 to
3defe3b
Compare
|
@swift-ci please smoke test |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work from #18344, be more conservative about when we load
SwiftOnoneSupport. Specifically, -emit-silgen and -emit-sibgen, despite
not going through the SIL Optimizer, may silently introduce dependencies
on SwiftOnoneSupport.
Because we want to support the ability to posthumously compile SILGen
and SIBGen'd files with these implicit dependencies, and because SIL
is not yet capable of expressing the dependency itself, we must always
assume we need to load SwiftOnoneSupport.