Skip to content

Added a test case for the const-folding crash due to MultipleValueInstructionResult #18412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

mhong
Copy link

@mhong mhong commented Jul 31, 2018

The bug was fixed in #18272.

Confirmed this test crashes without that fix.

MultipleValueInstructionResult, which got fixed in
swiftlang#18272.

Confirmed this test crashes without that fix.
@mhong
Copy link
Author

mhong commented Jul 31, 2018

@swift-ci please test tensorflow

@mhong mhong requested review from dan-zheng and rxwei July 31, 2018 20:50
@@ -351,3 +351,14 @@ func SR8316_main() {
let float: Float = 0.1 // expected-warning {{immutable value 'float' was never used}}
_ = SR8316_helper()
}

func readDataset() -> (images: Tensor<Float>, labels: Tensor<Int32>)? {
print("Reading the data.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: un-indent.

@mhong mhong merged commit 1e79e03 into swiftlang:tensorflow Aug 1, 2018
@mhong mhong deleted the const_fold_test_case branch August 1, 2018 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants