[SourceKit] Change return value of functions in EditorConsumer to void #18416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
commented
Jul 31, 2018
| @@ -1860,8 +1860,7 @@ void SwiftEditorDocument::readSemanticInfo(ImmutableTextSnapshotRef Snapshot, | |||
| UIdent Kind = SemaTok.getUIdentForKind(); | |||
| bool IsSystem = SemaTok.getIsSystem(); | |||
| if (Kind.isValid()) | |||
| if (!Consumer.handleSemanticAnnotation(Offset, Length, Kind, IsSystem)) | |||
| break; | |||
| Consumer.handleSemanticAnnotation(Offset, Length, Kind, IsSystem); | |||
There was a problem hiding this comment.
I changed the behavior here a bit, but it's only in the test consumers in which we would have previously taken an early exit here. I believe that the reduced complexity allows for slightly decreased performance in the test cases since the loop contains no long-running logic.
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
editorconsumer-return-values
branch
from
d10710f to
95ff7a9
Compare
We were always returning true from those functions in SKEditorConsumer and false in the test consumers. On the client side we would then ignore the return value. So it's clearer to have the functions not return anything.
ahoppen
force-pushed
the
editorconsumer-return-values
branch
from
95ff7a9 to
9bbe441
Compare
|
Fixed some merge conflicts. @swift-ci Please smoke test |
rintaro
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always returning
truefrom those functions in `SKEditorConsumer and false in the test consumers. On the client side we would then ignore the return value. So it's clearer to have the functions not return anything.