SwiftSyntaxTest: refactor command-line argument parsing into a test utility module. NFC #18418
Conversation
|
@swift-ci please smoke test |
| let argName: String | ||
|
|
||
| var errorDescription: String? { | ||
| return "Missing required argument: \(argName)" | ||
| } | ||
| } | ||
| struct UnkeyedArgumentError: LocalizedError { | ||
| fileprivate struct UnkeyedArgumentError: LocalizedError { |
There was a problem hiding this comment.
IMHO this should be public so that you can specifically catch the error. Same goes for MissingArgumentError.
| let argName: String | ||
|
|
||
| var errorDescription: String? { | ||
| return "Unexpectedly found command line argument \(argName) without a key" | ||
| } | ||
| } | ||
|
|
||
| private let args: [String: String] | ||
| fileprivate let args: [String: String] |
There was a problem hiding this comment.
Is there any reason why this an no longer be private?
There was a problem hiding this comment.
Not specifically; keeping it as private should be good enough.
There was a problem hiding this comment.
I always default to private because its less verbose and the stricter access level.
|
@swift-ci please smoke test |
|
@ahoppen do you mind if we change the flag style from "--flag" to "-flag" to match the conventions? |
No, I don't have strong opinions on this. |
|
@swift-ci please smoke test |
…tility module. NFC (swiftlang#18418)
No description provided.