[swiftSyntax] Incremental syntax classification #18424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ental transfer This way we will be able to avoid reclassifying these nodes for syntax highlighting since we know they haven't changed.
|
@swift-ci Please smoke test |
rintaro
approved these changes
Aug 2, 2018
nkcsgexi
approved these changes
Aug 3, 2018
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
…ation [swiftSyntax] Incremental syntax classification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are able to incrementally transfer the syntax tree but to receive information for syntax highlighting the
SyntaxClassifieralways needed to walk the entire tree. With this PR we are storing the IDs of the nodes that got reused as part of the last incremental transfer and are able to just reclassify the parts of the syntax tree that have changed since the last transfer.