Address review comments for deprecated warning on NSObject.hashValue override #18442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, these operations belong in the ObjectiveC module, where NSObject is defined. Keep them there. However, we need to build the mock ObjectiveC overlay with `-disable-objc-attr-requires-foundation-module` now.
DougGregor
force-pushed
the
warn-override-nsobject-hashvalue-fixes
branch
from
dc587c1 to
f39fe1a
Compare
|
@swift-ci please smoke test |
jrose-apple
reviewed
Aug 1, 2018
lib/Sema/TypeCheckDeclOverride.cpp
Outdated
| if (baseVar->getName() == ctx.Id_hashValue && | ||
| classDecl->getName().is("NSObject") && | ||
| (classDecl->getModuleContext()->getName().is("ObjectiveC") || | ||
| classDecl->getModuleContext()->getName().is("Foundation"))) { |
There was a problem hiding this comment.
I believe these two are also KnownIdentifiers. (We're not hugely consistent about what we use those for. Maybe it's less important for checking anyway.)
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the review comments from @jrose-apple and @lorentey on #18407, cleaning up my newly-introduced warning for overriding
NSObject.hashValue