[SourceKit] Syntax parsing performance improvements #18444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
nkcsgexi
approved these changes
Aug 2, 2018
This is faster than invoking getAbsolutePosition which needs to walk the tree again.
This will allow us to experiment with other serialization formats in the future more easily.
Heuristics have shown that this prevents several new mallocs and speeds incremental syntax tree transfer up.
…ialized completely
ahoppen
force-pushed
the
performance-improvements
branch
from
a14c459 to
b75dd68
Compare
|
Fixed some merge conflicts. @swift-ci Please smoke test and merge |
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles a bunch of small performance improvements for parsing a syntax tree from a Swift file using SourceKit.
The separate improvements are described in the respective commit messages.