[sil-serialization] Create SILSerializationFunctionBuilder and use it… #18445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
shajrawi
reviewed
Aug 1, 2018
There was a problem hiding this comment.
The idea itself looks good, but it doesn't compile as-is, need to fix that:
/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift/lib/Serialization/SILSerializationFunctionBuilder.h:32:25: error: use of undeclared identifier 'sourceLoc'
12:52:25 RegularLocation(sourceLoc), IsNotBare, IsNotTransparent,
12:52:25 ^
12:52:25 /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift/lib/Serialization/DeserializeSIL.cpp:555:9: error: no member named 'setIsThunk' in 'swift::SILFunction'; did you mean 'setThunk'?
|
Oops. |
… when deserializing. This allowed me to fold all of the weird direct calls to createFunction into a singular SILSerializationFunctionBuilder::createDeclaration. This is the only API that is needed by the SILParser so only providing that gives us a significantly cleaner API. rdar://42301529
gottesmm
force-pushed
the
pr-9dbfa583dcd9d9142811cf110463cc6459d0cac1
branch
from
f338f18 to
72d3323
Compare
|
Lets try this again. |
|
@swift-ci smoke test and merge |
3 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when deserializing.
This allowed me to fold all of the weird direct calls to createFunction into a
singular SILSerializationFunctionBuilder::createDeclaration. This is the only
API that is needed by the SILParser so only providing that gives us a
significantly cleaner API.
rdar://42301529