[upstream-update] Do not specify OpenFlags since it was removed upstr… #18472
Conversation
|
@swift-ci smoke test and merge |
gottesmm
force-pushed
the
pr-e32569f4f04c02ff378bcf2514fc38fcff9253b9
branch
from
80a6ce1 to
66c0b3c
Compare
|
@jrose-apple done. |
gottesmm
force-pushed
the
pr-e32569f4f04c02ff378bcf2514fc38fcff9253b9
branch
from
66c0b3c to
36b5fd3
Compare
lib/FrontendTool/FrontendTool.cpp
Outdated
| @@ -322,8 +322,8 @@ static bool atomicallyWritingToTextFile( | |||
|
|
|||
| bool actionFailed = false; | |||
| std::error_code EC = | |||
| swift::atomicallyWritingToFile(outputPath, /*binary*/false, | |||
| [&](llvm::raw_pwrite_stream &out) { | |||
There was a problem hiding this comment.
Indentation got messed up here.
There was a problem hiding this comment.
llvm style I think would say that it should be two. That being said. I am fine fixing it in a subsequent commit.
There was a problem hiding this comment.
Heh. I looked for it, actually, and they don't say anything about what to do when wrapping lines. I thought clang-format double-indented wrapped lines, but I might be misremembering.
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
|
Or I'll just fix it real quick |
…eam. This was removed upstream in https://reviews.llvm.org/D47789 since the only place this flag was used was in the windows implementation where the behavior triggered by this could be hidden in the implementation instead of being an argument. As such, this code doesn't compile on master-next. Since this has an acceptable default argument given the current stable, we can just fix this on master and everything will work. rdar://42862352
gottesmm
force-pushed
the
pr-e32569f4f04c02ff378bcf2514fc38fcff9253b9
branch
from
36b5fd3 to
7e70389
Compare
|
@swift-ci smoke test and merge |
5 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
https://reviews.llvm.org/D97785 reintroduced a flags parameter to `fs::createUniqueFile`, this time preceding `params`. (Compare: #18472) rdar://76036856
…eam.
This was removed upstream in https://reviews.llvm.org/D47789 since the only
place this flag was used was in the windows implementation where the behavior
triggered by this could be hidden in the implementation instead of being an
argument. As such, this code doesn't compile on master-next.
Since this has an acceptable default argument given the current stable, we can
just fix this on master and everything will work.
rdar://42862352