[IDE][NFC] Cleanup collectArgumentExpectation() #18535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last usage have been removed in c0f5711.
To 'collectPossibleParamLists()'.
This function get the index of specified expression in the arguments.
|
@swift-ci Please smoke test |
benlangmuir
reviewed
Aug 7, 2018
| } | ||
| } | ||
| auto &SM = DC.getASTContext().SourceMgr; | ||
| for (unsigned i = 0, n = tuple->getNumElements(); i != n; ++i) { |
There was a problem hiding this comment.
Why do we have both of these loops? Are there any cases found by the first loop that we couldn't find with the second?
There was a problem hiding this comment.
Not sure. I just inlined getPositionInTupleExpr() here, and I wanted to keep this PR strictly NFC. I'll do further improvements in follow-ups.
benlangmuir
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strictly NFC cleanups for
CompletionLookup::collectArgumentExpectation()