Preserve default argument text through serialization #18579
Conversation
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
| param->setDefaultArgumentKind(*defaultArg); | ||
| if (!blobData.empty()) | ||
| param->setDefaultValueStringRepresentation(blobData); |
There was a problem hiding this comment.
Probably I'm missing something. But, where the blobData come from? Isn't this StringRef backed by SmallVector<uint64_t, 64> scratch? Is it safe to store it in AST nodes as a StringRef?
There was a problem hiding this comment.
Ah, I read the source of BitstreamReader, and I understand it now :)
| // CHECK73-SAME: = [] | ||
| // CHECK73-SAME: = [:] | ||
| // FIXME: should be <syntaxtype.keyword>nil</syntaxtype.keyword> | ||
| // CHECK73-SAME: = nil |
There was a problem hiding this comment.
Do you know why this isn't getting the keyword treatment? Is it coming through as a "normal" default argument?
There was a problem hiding this comment.
Yeah, any explicitly-written non-magic-literal expression is still "normal". I suppose we could special-case "the single token 'nil'" and see if that works, but it didn't seem too important to me when other default arguments are also not syntax-highlighted.
There was a problem hiding this comment.
Huh, so are DefaultArgumentKind::NilLiteral (and the empty literals too I guess) unused?
There was a problem hiding this comment.
They're used by the importer, since synthesizing instructions and type-checking them would have been a pain. It also mattered back before default arguments were inlinable, because you definitely don't want to call a function just to get nil.
There was a problem hiding this comment.
I experimented with the "see if the expression is a NilLiteralExpr" approach and it fell over in Sema. It's probably still doable, but I think I'm just going to leave it for now.
This allows us to dump it in the generated interface, though it's still not syntax-highlighted. This is necessary for textual module interfaces, but it's also just a longstanding request for Xcode's "Generated Interface" / "Jump to Definition" feature. rdar://problem/18675831
jrose-apple
force-pushed
the
san-andreas-default
branch
from
3ef50c6 to
e4902b7
Compare
|
@swift-ci Please smoke test |
This allows us to dump it in the generated interface, though it's still not syntax-highlighted. This is necessary for textual module interfaces, but it's also just a longstanding request for Xcode's "Generated Interface" / "Jump to Definition" feature.
SR-2608 / rdar://problem/18675831