[Parse] Fixit for inserting 'if' for 'else ... {' all on one line. #18588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
rintaro
reviewed
Aug 9, 2018
test/stmt/statements.swift
Outdated
| _ = 42 | ||
| } | ||
| func IfStmt3() { | ||
| if 1 > 0 { | ||
| } else 1 < 0 { // expected-error {{expected '{' or 'if' after 'else'; did you mean to write 'if'?}} |
There was a problem hiding this comment.
Oh, is that the way to test fixits? I assume 9 is the column number?
There was a problem hiding this comment.
Yeah, usually, we don't add FixCode test case for testing fix-its like this. But I think it's OK to add it :)
|
@swift-ci please smoke test |
Fixes rdar://problem/33023297.
|
@swift-ci please smoke test |
rintaro
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only inserts the fixit when the
{is on the same line, e.g.The thinking being that it's not the right thing for (say) C-style code like
Fixes rdar://problem/33023297.