Add regression test for https://bugs.swift.org/browse/SR-5056 #18611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
jrose-apple
reviewed
Aug 9, 2018
| } | ||
| } | ||
|
|
||
| class SR5056C : SR5056B {} |
There was a problem hiding this comment.
Can you add a function that calls both initializers on C, just to prove that they are still present after all?
This looks like a subtle issue. It was broken in 4.1 and got fixed in 4.2, perhaps by the decl checker cleanups or some other change. I don't see many occurrences of 'required convenience' in the non-executable tests, period, so it's good to have a bit more coverage for this corner of the language.
slavapestov
force-pushed
the
new-test-old-fix
branch
from
671bf23 to
6459333
Compare
|
@swift-ci Please smoke test |
|
Ain't me: |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please clean smoke test Linux |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a subtle issue. It was broken in 4.1 and got fixed in
4.2, perhaps by the decl checker cleanups or some other change.
I don't see many occurrences of 'required convenience' in the
non-executable tests, period, so it's good to have a bit more
coverage for this corner of the language.