SwiftSyntax: some basic changes needed for Linux support #18638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @harlanhaskins |
|
@swift-ci please test |
| .appendingPathComponent("swiftc") | ||
| .deletingLastPathComponent(); | ||
| #if !os(macOS) | ||
| swiftcURL = swiftcURL.deletingLastPathComponent(); |
There was a problem hiding this comment.
Nitpick: no semicolon here or on line 159
| @@ -48,46 +48,53 @@ struct ProcessResult { | |||
| } | |||
| } | |||
|
|
|||
| @inline(__always) | |||
There was a problem hiding this comment.
I don't think this needs to be @inline(__always).
|
Small nitpicks, but thank you for tackling this! |
This adds a couple of changes to support building SwiftSyntax without an ObjC runtime as well as swift-corelibs-foundation instead of the ObjC Foundation implemetation. This is needed to support building SwiftSyntax on Linux.
compnerd
force-pushed
the
SwiftSyntax-port
branch
from
114c692 to
a4c604f
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
This is soon going to conflict with #18673 |
|
Okay, since this is ready, I'm going to merge this, and then @ahoppen can rebase/resolve the conflict. He is working on making the codebase more robust, so thats definitely a good change. This was less invasive though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of changes to support building SwiftSyntax without an ObjC
runtime as well as swift-corelibs-foundation instead of the ObjC Foundation
implemetation. This is needed to support building SwiftSyntax on Linux.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.