[Diagnostics] Improve simplifyLocator to extract arguments from unr…
#18640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diagnostic messages are going to be the same in both cases, but one example of affected expression is: enum Color {
static func frob(_ a : Int, b : inout Int) -> Color { ... }
}
var i : Int = 42
let _: Color = .frob(1, b: i) // diagnoses missing `&` at position of `i`. |
…esolved member calls Unresolved member calls e.g. `.foo(1, 2)` are unique in a way that they don't form regular application expressions. So let's teach `simplifyLocator` how to extract arguments from such calls based on locators like: `[UnresolvedMemberExpr -> apply argument -> comparing call argument # to parameter #]`. This helps to diagnose more failures via diagnostics attached to constraint system fixes.
xedin
force-pushed
the
improve-simplify-locator
branch
from
cbd9228 to
538e5e8
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…esolved member calls
Unresolved member calls e.g.
.foo(1, 2)are unique in a way thatthey don't form regular application expressions. So let's teach
simplifyLocatorhow to extract arguments from such callsbased on locators like:
[UnresolvedMemberExpr -> apply argument -> comparing call argument # to parameter #].This helps to diagnose more failures via diagnostics attached to
constraint system fixes.