Skip to content

SIL: Simplify SILLinkerVisitor::visitApplySubstitutions() #18662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2018
Merged

SIL: Simplify SILLinkerVisitor::visitApplySubstitutions() #18662

merged 1 commit into from
Aug 16, 2018

Conversation

slavapestov
Copy link
Contributor

We don't have to ask the substitution map to do lookups, just iterate
over the conformances directly.

@slavapestov
SIL: Simplify SILLinkerVisitor::visitApplySubstitutions()
7004f9a 
We don't have to ask the substitution map to do lookups, just iterate
over the conformances directly.
@slavapestov slavapestov requested a review from jckarter August 13, 2018 06:01
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

Interesting. compiler_crashers_2/0153-rdar39130543.swift no longer crashes... I'm going to see why before merging this, since its meant to be NFC.

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@jckarter
Copy link
Contributor

Thanks for cleaning this up!

@slavapestov slavapestov merged commit 46981fe into swiftlang:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @jckarter