[IDE] Don't walk to ExplicitCast expr twice in ModelASTWalker #18663
Conversation
|
@swift-ci Please smoke test |
|
Why are there 2 cast exprs, is this really necessary ? Are these 2 different ExplicitCastExpr* pointers or the same one showing up twice ? |
lib/IDE/SyntaxModel.cpp
Outdated
| for(unsigned i = 0, e = SE->getElements().size(); i != e; ++i) { | ||
| auto subExpr = SE->getElement(i); | ||
|
|
||
| if (i % 2 != 0 && isa<ExplicitCastExpr>(subExpr)) |
There was a problem hiding this comment.
If the pointer for the expression appears twice, can we use a pointer set here to exclude duplications? or do we actually create the same expression twice?
They are the 2 pointers to the same object. I think we can make not showing up 2 times, but it need non trivial changes to the pipeline. |
|
I suspect this is to make the even/odd aspect of SequenceExpr work. |
Yeah, but I think we can make it like |
rintaro
force-pushed
the
ide-rdar43135727
branch
from
596905c to
eb7d924
Compare
Explict cast expressions (i.e. 'as', 'as!`, 'as?', and 'is') appear twice in
'SequenceExpr'. For instance, 'a as B' is parsed as:
(sequence_expr
(unresolved_declref_expr name='a')
(coerce_expr writtenType='B')
(coerce_expr writtenType='B'))
This patch prevents ModelASTWalker from walking into them twice.
rdar://problem/43135727
rintaro
force-pushed
the
ide-rdar43135727
branch
from
eb7d924 to
fedc36e
Compare
|
@swift-ci Please smoke test |
Explicit cast expressions (i.e.
as,as!,as?, andis) appear twice inSequenceExpr. For instance,a as Bis parsed as:This patch prevents
ModelASTWalkerfrom walking into them twice.rdar://problem/43135727