[libSyntax] Support serializing the syntax tree as ByteTree #18690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
reviewed
Aug 14, 2018
| @@ -462,6 +480,8 @@ void handleRequestImpl(sourcekitd_object_t ReqObj, ResponseReceiver Rec) { | |||
| Opts.EnableStructure = EnableStructure; | |||
| Opts.EnableDiagnostics = EnableDiagnostics; | |||
| Opts.SyntaxTransferMode = syntaxTransferModeFromUID(TransferModeUID); | |||
| Opts.SyntaxSerializationFormat = | |||
| syntaxSerializationFormatFromUID(SerializationFormatUID); | |||
There was a problem hiding this comment.
This and syntaxTransferModeFromUID should return Optional, and return error response for invalid UID.
ahoppen
force-pushed
the
syntax-tree-as-bytetree
branch
from
fe7cd69 to
4cda5cb
Compare
|
@swift-ci Please smoke test |
rintaro
approved these changes
Aug 14, 2018
nkcsgexi
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hooks the ByteTree serializer up in SourceKit so that a ByteTree serialized syntax tree can actually be retrieved.