[libSyntax] Resolve a memory leak leaking the syntax tree #18698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously RawSyntaxCacheNode was not increasing the RawSyntax refCount and accessing a cached node would fail if the node had been deleted in the meantime. We weren't hitting this so far, because all nodes were allocated using a bump allocator and thus the underlying memory never freed.
This resolves a memory leak.
|
@swift-ci Please smoke test |
|
Looks like this might be causing failures on the ASAN bots: |
|
I'm investigating what the issue is. |
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Aug 15, 2018
|
I'm reverting the code that caused this issue for now in #18726. |
ahoppen
added a commit
that referenced
this pull request
Aug 15, 2018
[libSyntax] Partly revert #18698 to fix ASAN bot
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a memory leak that occurred if
RawSyntaxnodes are allocated without an arena usingoperator new. AParserUnitwould never release itsASTContextwhich in turn retains theSourceFileand thus the syntax tree. Deleting theASTContextresolves this leak.We need to then retain
RawSyntaxnodes fromRawSyntaxCacheNodeso they are not freed while still being referenced.