Fix static exclusivity verification for withoutActuallyEscaping. #18708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test. |
|
@swift-ci test source compatibility. |
|
Build failed |
|
@swift-ci smoke test. |
shajrawi
suggested changes
Aug 14, 2018
ConvertFunction and reabstraction thunks need this attribute. Otherwise, there is no way to identify that withoutActuallyEscaping was used to explicitly perform a conversion. The destination of a [without_actually_escaping] conversion always has an escaping function type. The source may have either an escaping or @NoEscape function type. The conversion itself may be a nop, and there is nothing distinctive about it. The thing that is special about these conversions is that the source function type may have unboxed captures. i.e. they have @inout_aliasable parameters. Exclusivity requires that the compiler enforce a SIL data flow invariant that nonescaping closures with unboxed captures can never be stored or passed as an @escaping function argument. Adding this attribute allows the compiler to enforce the invariant in general with an escape hatch for withoutActuallyEscaping.
DiagnoseStaticExclusivity no longer asserts as follows when non-escaping closures are passed to withoutActuallyEscaping: Applied argument must be @NoEscape function type: ... A partial_apply with @inout_aliasable may only be used as a @NoEscape function type argument. Subsequent commits will improve diagnostics to detect actual conflicts in these situations. Fixes <rdar://problem/43059088> Assertion in DiagnoseStaticExclusivity.
|
@shajrawi thanks, I almost forgot! |
|
@swift-ci smoke test. |
shajrawi
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a SIL attribute [without_actually_escaping].
Teach static exclusivity verification about withoutActuallyEscaping.
Fixes rdar://problem/43059088 Assertion in DiagnoseStaticExclusivity.