Skip to content

benchmarks: some additions to the reporting scripts #18709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

eeckstein
Copy link
Contributor

  • add an option to the bench_code_size script to separately report code size for the swift libraries
  • add an option to the compare_perf_tests script to output improvements and regressions in an single table.

…improvements and regressions in an single table.

Instead of separate tables. Only affects git and markdown output.
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit dbf27cf into swiftlang:master Aug 14, 2018
@eeckstein eeckstein deleted the bm-scripts branch August 14, 2018 22:18
@palimondo
Copy link
Contributor

@eeckstein What is the intended use of single-table option? It looks like it is not used by CI bots, yet (recent benchmark report). Right?

I had a minor conflict around this change and though I might also write a test for it, while I'm at it...

@eeckstein
Copy link
Contributor Author

I'd like to improve the output format of the benchmark report. But it's still in experimental phase. So it's not yet used by the bots

I had a minor conflict around this change and though I might also write a test for it, while I'm at it...

That would be cool!

@palimondo
Copy link
Contributor

I was asking, because it isn't clear to me what it should do… (it also isn't using the formatter correctly)

Can you hold on changing this for a moment? I'm nearing completion on my PR and like to finish it without more conflicts. I promise to get back to this and change it the way you'd like to to work. Could you describe what you're after in more details?

@eeckstein
Copy link
Contributor Author

Let me get back to you next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants