[ConstraintSystem] Don't try to eagerly deallocate fixes #18712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Fix` life-time is pretty limited as it is, and we'd have to distinguish between standalone fixes and ones attached to constraints, which is not worth the trouble. Resolves: rdar://problem/43285774
|
@swift-ci please ASAN test |
|
I have talked to @rudkx offline about this, and he is okay with this approach. |
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
|
Build failed |
|
Build failed because of this new LLDB issue @aschwaighofer Could you please force merge this to unblock ASAN bot? |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixlife-time is pretty limited as it is, and we'd haveto distinguish between standalone fixes and ones attached
to constraints, which is not worth the trouble.
Resolves: rdar://problem/43285774