[libSyntax] Generate TokenKinds.def from gyb_syntax_support #18715
+314
−358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
nkcsgexi
approved these changes
Aug 15, 2018
rintaro
approved these changes
Aug 15, 2018
rintaro
reviewed
Aug 15, 2018
utils/gyb_syntax_support/Token.py
Outdated
| PoundObjectLiteral('PoundImageLiteral', 'imageLiteral', | ||
| text='#imageLiteral', serialization_code=77, | ||
| description='color', | ||
| protocol='ExpressibleByColorLiteral'), |
There was a problem hiding this comment.
description and protocols are messed up.
ahoppen
force-pushed
the
gen-tokenkinds
branch
from
efbd47e to
9386e65
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
gen-tokenkinds
branch
from
9386e65 to
e9e7d5c
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not particularly nice to generate a
.deffile usinggybbut this eliminates the need to declare the same tokens twice, once for the Swift side and once for the C++ side.