[TBDGen] Allow user-provided dylib version flags #18716
Conversation
This patch adds two frontend arguments, -tbd-compatibility-version and -tbd-current-version, both of which accept SemVer versions. These will show up in the generated TBD file for a given module as current-version: 2.7 compatibility-version: 2.0 These flags both default to `1.0.0`.
|
@swift-ci please smoke test |
|
What breaks if the user doesn't specify these flags when emitting TBD files? |
|
Nothing ‘breaks’, per se, they just each default to |
| version::Version TBDCurrentVersion = {1, 0, 0}; | ||
|
|
||
| // The dylib compatibility-version to use in the generated TBD file. | ||
| version::Version TBDCompatibilityVersion = {1, 0, 0}; |
There was a problem hiding this comment.
I think we're going to want to just prepopulate TBDGenOptions soon, like we do with IRGenOptions, rather than pass everything through FrontendOptions. What do you think? (Probably for a follow-up, not here.)
There was a problem hiding this comment.
Yeah, that sounds good. I'll submit that cleanup in a follow-up patch.
| // RUN: %empty-directory(%t) | ||
| // RUN: %target-swift-frontend -emit-ir -o /dev/null %s -tbd-current-version 2.0.3 -tbd-compatibility-version 1.7 -emit-tbd -emit-tbd-path %t/both_provided.tbd | ||
| // RUN: %target-swift-frontend -emit-ir -o /dev/null %s -tbd-current-version 2.0 -emit-tbd -emit-tbd-path %t/only_current_provided.tbd | ||
| // RUN: %target-swift-frontend -emit-ir -o /dev/null %s -tbd-compatibility-version 2 -emit-tbd -emit-tbd-path %t/only_compat_provided.tbd |
There was a problem hiding this comment.
Can you add a test case for something that doesn't parse, to be sure that it produces a diagnostic?
|
@swift-ci please smoke test |
* [TBDGen] Allow user-provided dylib version flags This patch adds two frontend arguments, -tbd-compatibility-version and -tbd-current-version, both of which accept SemVer versions. These will show up in the generated TBD file for a given module as current-version: 2.7 compatibility-version: 2.0 These flags both default to `1.0.0`. * Reword some comments * Add test for invalid version string * Expand on comments for TBD flags
* [TBDGen] Allow user-provided dylib version flags This patch adds two frontend arguments, -tbd-compatibility-version and -tbd-current-version, both of which accept SemVer versions. These will show up in the generated TBD file for a given module as current-version: 2.7 compatibility-version: 2.0 These flags both default to `1.0.0`. * Reword some comments * Add test for invalid version string * Expand on comments for TBD flags
This patch adds two frontend arguments,
-tbd-compatibility-versionand-tbd-current-version, both of which accept SemVer versions.These will show up in the generated TBD file for a given module as
These flags both default to
1.0.0, and TAPI will not write them in the .tbd file if they're 1.Resolves: rdar://34560882