[CodeCompletion] Remove unresolved type in prepareForRetypechecking() #18721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unresolved type attached to expressions may fail re-typechecking. Also, disallow unresolved type in typeCheckCompletionSequence(). It doesn't provide useful completions to developers. rdar://problem/41224316
in PotentialBindings::addPotentialBinding()
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Aug 15, 2018
|
@rintaro When exactly does code completion need to recheck expressions multiple times? It would be nice to avoid that. Could it at least get the type, without applying a solution? |
|
@slavapestov When finding postfix completion, in current implementation, code-completion tries type checking for each potential operators reusing LHS. Although these typecheck is not so heavy operation as the type of LHS is pre-determined, team and I agree this is not the best solution. I will pursue a solution without rechecking. |
|
@swift-ci Please smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unresolved type attached to expressions may fail re-typechecking. Reset them to null type so it properly re-typechecked.
Also, disallow unresolved type in
typeCheckCompletionSequence(). It doesn't provide useful completions to developers.rdar://problem/41224316