[TBDGen] Remove TBD options from FrontendOptions #18736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
Aug 15, 2018
| }; | ||
|
|
||
| /// Compare the symbols in the IR against the TBD file we would generate. | ||
| TBDValidationMode ValidateTBDAgainstIR = TBDValidationMode::Default; |
There was a problem hiding this comment.
This one, actually, still seems like a Frontend option to me. After all, it requires both TBDGen and IRGen to run. What do you think?
There was a problem hiding this comment.
Hmm, yeah that's a good point. I suppose I should return that to FrontendOptions and actually add a diagnostic preventing you from passing that flag if IR isn't being generated.
lib/Frontend/CompilerInvocation.cpp
Outdated
| Opts.InstallName = A->getValue(); | ||
| } | ||
| if (Opts.InstallName.empty()) { | ||
| Opts.InstallName = ("lib" + Invocation.getModuleName() + ".dylib").str(); |
There was a problem hiding this comment.
I guess this was already there, but honestly it doesn't seem like there's a reasonable default here at all. Empty might actually be better for platforms that don't use install names.
added 2 commits
August 15, 2018 14:53
This patch removes the duplication between FrontendOptions and TBDGenOptions by parsing the TBDGenOptions up front similarly to IRGen and SIL options.
harlanhaskins
force-pushed
the
magic-eraser
branch
from
a37ae7f to
75e2195
Compare
|
@swift-ci please smoke test |
|
LLDB build failure seems unrelated. @swift-ci please smoke test |
jrose-apple
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the duplication between FrontendOptions and
TBDGenOptions by parsing the TBDGenOptions up front similarly to IRGen
and SIL options.