swift-api-digester: diagnose the addition and removal of @objc, @_fixed_layout and @_frozen under ABI mode. #18739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
reviewed
Aug 15, 2018
| ABIAttrs.push_back({DeclAttrKind::DAK_ObjC, NodeAnnotation::ObjCChange, | ||
| "@objc"}); | ||
| ABIAttrs.push_back({DeclAttrKind::DAK_FixedLayout, | ||
| NodeAnnotation::FixedLayoutChange, "@_fixed_layout"}); |
There was a problem hiding this comment.
Can you metaprogram these so you're not duplicating attribute names from include/swift/AST/Attrs.def?
There was a problem hiding this comment.
I plan to refactor this code piece so we don't need to define these NodeAnnotation at all. That'll be a bigger patch in the next PR or so.
test/api-digester/Inputs/cake2.swift
Outdated
| public class C4: NewType {} | ||
|
|
||
| @_fixed_layout |
There was a problem hiding this comment.
A better example would be to apply this to a struct not a class. We might decide not to allow it on classes altogether.
…ed_layout and @_frozen under ABI mode.
|
@swift-ci please smoke test |
nkcsgexi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.