[stdlib] Migrate remaining stdlib tests from Swift 3 #18740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
airspeedswift
commented
Aug 15, 2018
| @@ -542,7 +542,7 @@ ArrayTestSuite.test("BridgedToObjC/Verbatim/objectAtIndex") { | |||
| expectEqual(30, (v as! TestObjCValueTy).value) | |||
| let idValue2 = unsafeBitCast(v, to: UInt.self) | |||
|
|
|||
| for i in 0..<3 { | |||
| for _ in 0..<3 { | |||
There was a problem hiding this comment.
Pretty sure this test is buggy, and the intention was to actually loop over something or not to loop at all...
There was a problem hiding this comment.
Yes, I think it can be removed.
| @@ -24,11 +18,11 @@ class Derived2 : Derived { } | |||
| ArrayTraps.test("downcast1") | |||
| .skip(.custom( | |||
| { _isFastAssertConfiguration() }, | |||
| reason: "this trap is not guaranteed to happen in -Ounchecked")) | |||
| reason: "this trap is not guaranteed to happen in -Unchecked")) | |||
There was a problem hiding this comment.
My working theory is I fat-fingered a spellcheck keypresss...
| expectSameType(Int64.self, IntMax.self) | ||
| expectSameType(UInt64.self, UIntMax.self) | ||
| expectSameType(Int64.self, IntMax.self) // expected-error {{'IntMax' has been renamed to 'Int64'}} | ||
| expectSameType(UInt64.self, UIntMax.self) // expected-error {{'UIntMax' has been renamed to 'UInt64'}} |
There was a problem hiding this comment.
Hmmm, we should fix this error message to something that tells people what to do instead of using [U]IntMax. That's separate from this PR, though.
|
@swift-ci please test |
|
LGTM. |
lorentey
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some drive-by warning fixes and de-gybbing a file that wasn't using gyb.
Where there was a test for multiple versions, I've dropped 3 and added 4.2 (if it wasn't there). Where it was just testing Swift 3, I've bumped it to 4.2 (maybe we should add 4, 4.2 and 5 to everything... but that'd be a lot more tests).
Main things that needed fixing:
AnyObject@objc