[Diagnostics] Extract requirement declaration context retrieval into … #18752
Conversation
…its own method Change logic to traverse the chain of declaration contexts starting for "affected" declaration's parent and check if the requirement is satisfied by one of them, if so return it as requirement's declaration context. Extract this logic into a method on `RequirementFailure` to make it accessible for other types of requirement failure diagnostics.
|
@swift-ci please test |
|
Build failed |
| break; | ||
|
|
||
| if (auto *GC = D->getAsGenericContext()) { | ||
| auto *sig = GC->getGenericSignature(); |
There was a problem hiding this comment.
This looks like you just want DC->getGenericSignatureOfContext() and avoid all this?
There was a problem hiding this comment.
I don't think I can because getGenericSignatureOfContext is going to traverse parents until it finds one with generic signature and it would only return signature from it, but I wouldn't know which parent that was.
There was a problem hiding this comment.
getGenericSignatureOfContext() does not traverse parents, but non-generic decls in generic context inherit the generic signature of their parent, so getGenericSignature() has the same behavior.
There was a problem hiding this comment.
Good to know, I'll give it a try.
|
@swift-ci please test Linux platform |
…its own method
Change logic to traverse the chain of declaration contexts
starting for "affected" declaration's parent and check if the
requirement is satisfied by one of them, if so return it as
requirement's declaration context.
Extract this logic into a method on
RequirementFailureto makeit accessible for other types of requirement failure diagnostics.