Skip to content

[test] Check for sftp-server for remote-run --debug-as-local tests #18759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

jrose-apple
Copy link
Contributor

Not all systems have sftp-server installed.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@davezarzycki
Copy link
Contributor

Hey @jrose-apple – While I'm testing this, can you update the pull request to look for sftp-server here: /usr/libexec/openssh/sftp-server? That's where Red Hat Fedora installs it.

@jrose-apple
Copy link
Contributor Author

Huh, Ubuntu also put it in an openssh subdirectory but with a symlink from /usr/lib/. I guess OpenSSH is common enough to be worth hardcoding.

Not all systems have sftp-server installed.
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@davezarzycki davezarzycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that 6e04cd303210a17d56f062796c88fc95bd4c5393 works. Also, ya, there is an implicit dependency on OpenSSH's version of sftp-server here.

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrose-apple jrose-apple merged commit 1f9ef88 into swiftlang:master Aug 16, 2018
@jrose-apple jrose-apple deleted the serverless branch August 16, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants