Skip to content

[Stats] Change NumInstructions to NumInstructionsExecuted, accept 0 when on VMs. #18762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2018
Merged

[Stats] Change NumInstructions to NumInstructionsExecuted, accept 0 when on VMs. #18762

merged 1 commit into from
Aug 16, 2018

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Aug 16, 2018

Renames the counter to something a little more explicit before we get too used to the other one (requested by @gottesmm)

@graydon graydon requested a review from gottesmm August 16, 2018 20:23
@graydon
Copy link
Contributor Author

graydon commented Aug 16, 2018

@swift-ci please test and merge

gottesmm
gottesmm approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@swift-ci swift-ci merged commit e0cef24 into swiftlang:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottesmm gottesmm gottesmm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graydon @gottesmm @swift-ci