Tweak Parse and SILGen to support loading swiftinterface files #18764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to do need to do more here for inlinable accessors, which /do/ have bodies, but this helps us get to a bare minimum testing configuration.
|
@swift-ci Please smoke test |
lib/SILGen/SILGen.cpp
Outdated
| @@ -778,7 +778,7 @@ void SILGenModule::emitConstructor(ConstructorDecl *decl) { | |||
|
|
|||
| // If this constructor was imported, we don't need the initializing | |||
There was a problem hiding this comment.
Can you update this comment to account for the behavior change?
There was a problem hiding this comment.
Heh, I was banking on the double meaning of "imported", but you're right.
harlanhaskins
approved these changes
Aug 16, 2018
jrose-apple
force-pushed
the
smoke-rings
branch
from
8fc9e1e to
5b23cf8
Compare
|
@swift-ci Please smoke test |
|
Whoops, this breaks |
jrose-apple
force-pushed
the
smoke-rings
branch
from
5b23cf8 to
a2ed23f
Compare
|
@swift-ci Please smoke test |
|
…still got it wrong. I should just run the full test suite locally before the next try. |
The presence of a deinitializer will eventually indicate whether a class's deinitializer is non-trivial for non-resilient modules. Also improve recovery for normal source files for various bad ways of declaring a deinitializer.
jrose-apple
force-pushed
the
smoke-rings
branch
from
a2ed23f to
29ac717
Compare
|
@swift-ci Please smoke test |
No functionality change.
I was surprised to see this parses fine already, but SILGen still needs a new check.
This is not an exhaustive test of language features, but it at least checks that the simple stuff is working.
jrose-apple
force-pushed
the
smoke-rings
branch
from
29ac717 to
1a3cb5b
Compare
|
@swift-ci Please smoke test |
| @@ -17,8 +17,8 @@ struct FooStructConstructorC { | |||
|
|
|||
| struct FooStructDeinitializerA { | |||
| deinit // expected-error {{expected '{' for deinitializer}} | |||
| deinit x // expected-error {{deinitializers cannot have a name}} {{10-12=}} | |||
| deinit x() // expected-error {{deinitializers cannot have a name}} {{10-11=}} | |||
| deinit x // expected-error {{deinitializers cannot have a name}} {{10-12=}} expected-error {{expected '{' for deinitializer}} | |||
There was a problem hiding this comment.
Small drive-by diagnostic improvement too!
harlanhaskins
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle accessors, initializers, and deinitializers without bodies, which will all appear in textual interface files.