Stop printing access on extensions and protocol requirements #18772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ends up meaning "don't print access attributes, then print access uniformly on ValueDecls if you're not printing access attributes".
We might allow this at some point in the future, but for now we should stick to the syntax that people write in source. rdar://problem/26746605
|
@swift-ci Please test |
nkcsgexi
approved these changes
Aug 16, 2018
harlanhaskins
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On extensions it's not really interesting (since it's just a default for the members), and for protocol requirements it's not something you can write in source at all.
SR-3540 / rdar://problem/26746605