Skip to content

[Diagnostics] NFC: Move logic common to all requirement failures into… #18780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Aug 17, 2018

RequirementFailure

This is going to make adding same-type and superclass requirement
failures might easier, because they only have to supply custom
diagnostic messages and substituted types.

… `RequirementFailure`

This is going to make adding same-type and superclass requirement
failures might easier, because they only have to supply custom
diagnostic messages and substituted types.
@xedin xedin requested a review from rudkx August 17, 2018 01:36
@xedin
Copy link
Contributor Author

xedin commented Aug 17, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6756c57

@xedin
Copy link
Contributor Author

xedin commented Aug 17, 2018

@swift-ci please test Linux platform

Copy link
Contributor

@rudkx rudkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xedin xedin merged commit 1ea3ebc into swiftlang:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants