[analysis] Turn on the pass manager notification verifier analysis. #18781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of SILFunction pointers for its internal state. This enables us to have state independent of the liveness of the SILFunction's that we are tracking. I also changed the verifier to implement only verifyFull instead of verify to ensure that when we run with sil-verify-all this only runs at the end of pass manager pipelines. rdar://42301529
When asserts are enabled this tracks the add/delete notifications from the SILPassManager it belongs to. When the SILPassManager is destroyed, the analysis verifies that it worked correctly by looping over all the functions in the module and verifying that its internal state is consistent with the module. This will ensure we never lose add/delete notification events ever again by mistake. rdar://42301529
|
@swift-ci smoke test |
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci smoke benchmark |
|
Doing a bunch of testing to make sure I don't break anything by turning this on. |
|
I am going to kill the smoke test jobs |
|
This turns on #18781. |
|
Erm: #18767. |
|
I am going to test perf as well. If this is too expensive to run normally, then I will only have it run at end of pipeline with -sil-verify-all enabled. |
|
@swift-ci test compiler performance |
Build comment file:Optimized (O)Regression (6)
Improvement (3)
No Changes (438)
Hardware Overview |
|
And may we never speak of missing pass manager notifications... ever again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When asserts are enabled this tracks the add/delete notifications from the
SILPassManager it belongs to. When the SILPassManager is destroyed, the analysis
verifies that it worked correctly by looping over all the functions in the
module and verifying that its internal state is consistent with the module.
This will ensure we never lose add/delete notification events ever again by
mistake.
rdar://42301529
NOTE: The second commit is in a different PR. I just wanted to do some parallel testing.