Skip to content

Remove now-unnecessary expr_swift_keypath_unimplemented_component diagnostic #18818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

Remove now-unnecessary expr_swift_keypath_unimplemented_component diagnostic #18818

merged 1 commit into from
Aug 21, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Aug 18, 2018

I assume that the last usage of the diagnostic had been removed in #11730.

@ikesyo
Copy link
Member Author

ikesyo commented Aug 18, 2018

@swift-ci Please smoke test

@ikesyo
Copy link
Member Author

ikesyo commented Aug 21, 2018

Any problem?

@gottesmm gottesmm requested a review from jckarter August 21, 2018 17:12
@gottesmm
Copy link
Contributor

@jckarter I think this is fine, no?

@jckarter
Copy link
Contributor

Looks good, thanks!

@jckarter jckarter merged commit ae2a5cf into swiftlang:master Aug 21, 2018
@ikesyo ikesyo deleted the remove-unused-error-diag branch August 31, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter Awaiting requested review from jckarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikesyo @gottesmm @jckarter