Replace materializeForSet with the modify coroutine #18840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test OS X. |
rjmccall
force-pushed
the
dematerializeForSet
branch
from
c08b927 to
70aa1bc
Compare
|
@swift-ci Please smoke test. |
rjmccall
force-pushed
the
dematerializeForSet
branch
from
70aa1bc to
96bc6dd
Compare
|
@swift-ci Please smoke test. |
rjmccall
force-pushed
the
dematerializeForSet
branch
from
96bc6dd to
abe0d30
Compare
|
@swift-ci Please smoke test. |
rjmccall
force-pushed
the
dematerializeForSet
branch
from
abe0d30 to
c389f8b
Compare
|
@swift-ci Please test. |
|
Build failed |
|
Build failed |
rjmccall
force-pushed
the
dematerializeForSet
branch
from
46ae169 to
de5e875
Compare
|
@swift-ci Please test. |
|
Build failed |
|
Build failed |
|
Preliminary code size numbers look good: https://gist.github.com/rjmccall/385ca49b3c5dc9ec01ba3af05fcd6e67 |
rjmccall
force-pushed
the
dematerializeForSet
branch
2 times, most recently
from
753216f to
411fc9f
Compare
|
@swift-ci Please test. |
|
Build failed |
|
Build failed |
|
@swift-ci Please test source compatibility. |
|
@swift-ci Please test performance. |
|
@swift-ci Please benchmark. |
|
@swift-ci please smoke benchmark staging |
|
!!! Couldn't read commit file !!! |
rjmccall
changed the title
|
Four failures: the Linux build failure and compatibility-suite failures in Chatto, IBAnimatable, and ProcedureKit. The Chatto regression is hopefully being fixed by @slavapestov's #18978, and ProcedureKit is fixed by #18981. So that's progress. |
Build comment file:Optimized (O)Regression (9)
Improvement (7)
No Changes (458)
Unoptimized (Onone)Regression (55)
Improvement (32)
No Changes (387)
Hardware Overview |
|
@swift-ci Please test. |
1 similar comment
|
@swift-ci Please test. |
|
Build failed |
|
Build failed |
|
@swift-ci Please test. |
|
Build failed |
|
@swift-ci Please test OS X. |
|
@swift-ci Please test source compatibility. |
1 similar comment
|
@swift-ci Please test source compatibility. |
For the most part, code should be working with the as-declared abstraction pattern of the storage, because that's the pattern produced by its accessors. However, in the special case of an accessor synthesized on demand to satisfy a protocol conformance, that accessor will use the native abstraction pattern of the declaration, and so the witness thunk that uses that accessor must use that pattern when generating its access. This doesn't matter today because the only on-demand synthesized accessor is materializeForSet, and witnesses for materializeForSet don't actually call the synthetic materializeForSet --- in fact, nothing does. But the modify accessor uses the otherwise-standard pattern where the witness modify calls the concrete modify, and that modify currently uses the native abstraction pattern.
As always, most of the work here went into working around the AST representations of parameter and argument lists.
Most of this patch is just removing special cases for materializeForSet or other fairly mechanical replacements. Unfortunately, the rest is still a fairly big change, and not one that can be easily split apart because of the quite reasonable reliance on metaprogramming throughout the compiler. And, of course, there are a bunch of test updates that have to be sync'ed with the actual change to code-generation. This is SR-7134.
rjmccall
force-pushed
the
dematerializeForSet
branch
from
b2f51c6 to
b80618f
Compare
|
@swift-ci Please test. |
|
@swift-ci Please test source compatibility. |
|
@swift-ci Please test. |
1 similar comment
|
@swift-ci Please test. |
|
Please? |
|
@swift-ci Please test. |
|
Build failed |
|
@swift-ci Please test OS X. |
|
@swift-ci Please smoke benchmark staging. |
|
!!! Couldn't read commit file !!! |
|
@swift-ci Please smoke benchmark staging. |
Build comment file:Performance: -O
Performance: -Osize
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR. Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein). Hardware Overview |
|
Internal performance analysis checks out. Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this patch is just removing special cases for
materializeForSetor other fairly mechanical replacements. Unfortunately, the rest is still a fairly big change, and not one that can be easily split apart because of the quite reasonable reliance on metaprogramming throughout the compiler. And, of course, there are a bunch of test updates that have to be sync'ed with the actual change to code-generation.This is SR-7134.