Skip to content

[SourceKit] Remove option to regions reused as part of incremental parsing #18848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 20, 2018

Passing pack the reuse regions of incremental parsing was only necessary to bootstrap incremental syntax parsing as a first feedback loop.

With the incremental syntax tree transfer the client may recover this information by inspecting which nodes were omitted in a transfer and for testing purposes swift-syntax-test still supports printing the reuse regions.

@ahoppen ahoppen requested a review from nkcsgexi August 20, 2018 18:18
@ahoppen
Copy link
Member Author

ahoppen commented Aug 20, 2018

@swift-ci Please smoke test

@ahoppen ahoppen merged commit b735673 into swiftlang:master Aug 21, 2018
@ahoppen ahoppen deleted the remove-reuse-regions branch August 22, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants