Check default arguments even if a function has no body #18864
Conversation
|
@swift-ci Please test |
|
Build failed |
|
Oops. I saw that this test failed, but it's relying on old behavior of SourceLoader and isn't worth preserving. |
jrose-apple
force-pushed
the
never-default-on-your-defaults
branch
from
a50553a to
1a88fbf
Compare
|
@swift-ci Please test |
This is needed for textual interfaces, but the behavior doesn't have to be specific to that, since functions without bodies don't come up in other situations.
|
Build failed |
|
Build failed |
|
Build failed |
These three again. @dcci, maybe it's worth re-excluding them for now? |
|
@swift-ci Please test Linux |
|
@jrose-apple yes, I think we should exclude them again (cc: @fredriss/ @vedantk) |
|
In fact, I thought they're still excluded (they're still marked as swift-test, but not swift-pr). I think this is because we now run the full suite (sorry I don't have more details, this was presumably deployed last week when I was out). |
|
The swiftpr test whitelist was disabled recently. I filed a bug tracking a fix to the underlying issue with these tests. I'll mark these tests as being fully skipped for now. |
This is needed for textual interfaces, but the behavior doesn't have to be specific to that, since functions without bodies don't come up in other situations.