[swiftSyntax] Performance improvements for deserialising ByteTrees #18888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
reviewed
Aug 22, 2018
| @@ -48,32 +48,34 @@ protocol ByteTreeObjectDecodable { | |||
| /// - numFields: The number of fields that are present in the serialized | |||
| /// object | |||
| /// - Returns: The deserialized object | |||
| static func read(from reader: ByteTreeObjectReader, numFields: Int, | |||
| userInfo: [ByteTreeUserInfoKey: Any]) -> Self | |||
| static func read(from reader: UnsafeMutablePointer<ByteTreeObjectReader>, | |||
There was a problem hiding this comment.
So why not inout ByteTreeObjectReader?
There was a problem hiding this comment.
Because inout ByteTreeObjectReader still has a retain/release count associated with it.
nkcsgexi
approved these changes
Aug 27, 2018
ahoppen
force-pushed
the
swiftsyntax-performance-improvments
branch
from
6f3c306 to
31db50e
Compare
ahoppen
force-pushed
the
swiftsyntax-performance-improvments
branch
from
31db50e to
a7942e1
Compare
|
@swift-ci Please smoke test and merge |
|
Bots were unable to clone the projects. Let's try again. @swift-ci Please smoke test and merge |
|
Let's see if swift-ci is working again. @swift-ci Please smoke test and merge |
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
swiftsyntax-performance-improvments
branch
from
a7942e1 to
d41af61
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several performance for deserialising syntax trees in binary encoding (see the separate commits):
SourceLengtha structRawSyntaxDataa direct enumByteTree(Object)Readera struct and pass a reference to it around using anUnsafeMutabelPointeruserInfothrough anUnsafePointerand don't pass it around