Build libdispatch with the stdlib build type on linux when building #18898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcekit We were using the tools build type before. rdar://43516251
|
@swift-ci Please test |
|
I think this is reasonable in the short term to fix the bot. Now that I am thinking about it, longer term I wonder if libdispatch should have its own build debug flag. |
|
Copying the analysis over from the other PR: The fix for linking in SwiftOnoneSupport appropriately in libdispatch now changed the behaviour such that libdispatch is built in release mode which exposes known leaks via LSAN. This is trying to cover that up by building libdispatch in the same mode as the swift stdlib. |
|
Compnerd and I are talking about this. I think we have a better solution. I asked Arnold if I could close this so no one merges. He said it was ok (we can always reopen)... Closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourcekit
We were using the tools build type before.
rdar://43516251