Skip to content

[libSyntax] Make the ByteTree protocol version consist of a major and minor component #18905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 22, 2018

The idea is that we can increment the minor version if we do forward-compatible changes as described in #18889 and only need to increment the major version if we do changes that will disallow older version of swiftSyntax to read the syntax tree.

@ahoppen ahoppen requested review from rintaro and nkcsgexi August 22, 2018 18:40
@ahoppen
Copy link
Member Author

ahoppen commented Aug 22, 2018

@swift-ci Please smoke test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@ahoppen ahoppen force-pushed the semantic-version-number branch from 02ef26e to 49d0d5b Compare August 29, 2018 20:41
@ahoppen
Copy link
Member Author

ahoppen commented Aug 29, 2018

@swift-ci Please smoke test

@ahoppen
Copy link
Member Author

ahoppen commented Aug 29, 2018

@swift-ci Please smoke test Linux platform

@ahoppen ahoppen merged commit 5f34199 into swiftlang:master Aug 29, 2018
@ahoppen ahoppen deleted the semantic-version-number branch August 29, 2018 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants