Make sure to allow '@objc' on enum elements #18910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they were ignored by the checking of '@objc', but in the refactoring to a request the attribute started getting marked as invalid without a diagnostic. rdar://problem/43401047
This isn't just an optimization; we weren't recording that the attribute was invalid, and so it was getting /treated as valid/ when the module was imported into a client later. This would have caught the issue fixed by the previous commit.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
DougGregor
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously enum elements were ignored by the checking of
@objc, but in the refactoring to a request (#17976) the attribute started getting marked as invalid without a diagnostic.Why didn't we catch this sooner? Because it turns out we were serializing invalid attributes, which is definitely a bug because they'd be deserialized as valid. So, stop doing that too.
rdar://problem/43401047