Fix a warning in LICM in release builds #18998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
shajrawi
referenced
this pull request
Aug 27, 2018
…eed to be executed In some instances, some instructions, like ref_element_addr, can be hoisted outside of loops even if they are not guaranteed to be executed. We currently don’t support that / bail. We only try to do so / do further analysis only for begin_access because they are extremely heavy. However, we need to support hosting of ref_element_addr in that case, if it does not have a loop dependent operand, in order to be able to hoist begin_access instructions in some benchmarks. Initial local testing shows that this PR, when we enable exclusivity, improves the performance of a certain internal benchmark by over 40% See rdar://problem/43623829
|
@swift-ci Please smoke test and merge |
|
@swift-ci Please smoke test OS X |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/43623829