[Foundation] Collapse (SignedInteger|UnsignedInteger) reqts into FixedWidthInteger #19006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
jrose-apple
suggested changes
Aug 27, 2018
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test Linux |
4 similar comments
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
|
Build failed |
jrose-apple
approved these changes
Aug 28, 2018
DougGregor
force-pushed
the
error-bridging-integer-type
branch
from
4536099 to
d1d85aa
Compare
…dWidthInteger. Simplify the default implementations provided for RawRepresentable error types whose raw values are integral, replacing duplicated code (for SignedInteger or UnsignedInteger) with a single constraint on BinaryInteger. Fixes rdar://problem/35230187.
When working with Error types with unsigned raw values, numeric-cast into a UInt and then map the bits over to an Int so we preserve values not representable in an Int without wrapping. Thanks to @jrose-apple for pointing this out!
DougGregor
force-pushed
the
error-bridging-integer-type
branch
from
d1d85aa to
f64d5db
Compare
|
@swift-ci please smoke test |
|
Corelibs Foundation bit is in swiftlang/swift-corelibs-foundation#1675 |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the default implementations provided for RawRepresentable
error types whose raw values are integral, replacing duplicated code
(for SignedInteger or UnsignedInteger) with a single constraint on
BinaryInteger.
Fixes rdar://problem/35230187.