Break Driver's dependency on Frontend #19012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sink OutputFileMap{.h,.cpp} and ReferenceDependencyKeys.h to Basic
- Remove unnecessary includes of Frontend.h.
But not even that much uglier; at all three call sites this will save an allocation, and for the most important one (SourceKit) we can now avoid creating a temporary CompilerInvocation just to copy into a longer-lived one. With this change, Driver no longer depends on Frontend, which means... well, slightly faster builds of the compiler itself, but not much else.
|
@swift-ci Please clean test |
jrose-apple
commented
Aug 28, 2018
| @@ -1,4 +1,4 @@ | |||
| //===--- OutputFileMap.cpp - Driver output file map -----------------------===// | |||
| //===--- OutputFileMap.h - Map of inputs to multiple outputs --------------===// | |||
There was a problem hiding this comment.
Ugh, I just merged before spotting the typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main tricky part here was
driver::createCompilerInvocation, but it turned out that the part of that that actually used Frontend wasn't the important part. I changed it into a function with a callback,driver::getSingleFrontendInvocationFromDriverArguments, and it actually resulted in some (tiny) improvements even with the minor additional duplication at call sites.There's not such a big win from this or anything, but it'd been bothering me for a while. No user-visible functionality change.