Skip to content

[stdlib] Partially ungyb Integers #19036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2018
Merged

[stdlib] Partially ungyb Integers #19036

merged 1 commit into from
Aug 31, 2018

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Aug 29, 2018

The new file straucture is similar to that of floating point types,
where protocols live in one file, and concrete types – in another.

@moiseev
Copy link
Contributor Author

moiseev commented Aug 29, 2018

@stephentyrone 's idea.

@moiseev
Copy link
Contributor Author

moiseev commented Aug 29, 2018

@swift-ci Please test

moiseev
moiseev commented Aug 29, 2018
View reviewed changes
stdlib/public/core/Integers.swift Outdated
// that shift < Self.bitWidth. Not masking results in
// infinite recursion.
result ^= Self(_truncatingBits: neg ? ~word : word) &<< shift
shift += Self(Int.bitWidth)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried about this line. It used to be a literal instead of a Self(Int.bitWidth)...

@moiseev
Copy link
Contributor Author

moiseev commented Aug 29, 2018

@swift-ci please test compiler performance

@moiseev
Copy link
Contributor Author

moiseev commented Aug 29, 2018

@swift-ci Please benchmark

@moiseev moiseev requested a review from airspeedswift August 29, 2018 00:31
@swift-ci
Copy link
Contributor

!!! Couldn't read commit file !!!

@swift-ci
Copy link
Contributor

Build comment file:

Build failed before running benchmark.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - f04cd628aac26de3c337bb259a1550a0094a6dd0

@moiseev
[stdlib] Partially ungyb Integers
dca1ad8 
The new file straucture is similar to that of floating point types,
where protocols live in one file, and concrete types – in another.
@moiseev
Copy link
Contributor Author

moiseev commented Aug 29, 2018

@swift-ci Please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - f04cd628aac26de3c337bb259a1550a0094a6dd0

@moiseev
Copy link
Contributor Author

moiseev commented Aug 29, 2018

@swift-ci Please smoke test Linux platform

@moiseev
Copy link
Contributor Author

moiseev commented Aug 30, 2018

@swift-ci Please smoke test macOS platform

@moiseev
Copy link
Contributor Author

moiseev commented Aug 30, 2018

@swift-ci Please benchmark

@moiseev
Copy link
Contributor Author

moiseev commented Aug 30, 2018

@swift-ci Please test compiler performance

@swift-ci
Copy link
Contributor

!!! Couldn't read commit file !!!

@swift-ci
Copy link
Contributor

Build comment file:

Performance: -Onone

TEST OLD NEW DELTA SPEEDUP
Improvement
CharIndexing_tweet_unicodeScalars 767940 690931 -10.0% 1.11x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview 
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@moiseev
Copy link
Contributor Author

moiseev commented Aug 30, 2018

@swift-ci Please test macOS platform

@stephentyrone
Copy link
Contributor

finally

@stephentyrone stephentyrone mentioned this pull request Aug 31, 2018
Merged
@moiseev moiseev merged commit b4e7cc8 into swiftlang:master Aug 31, 2018
@moiseev moiseev deleted the ungyb-int branch August 31, 2018 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moiseev @swift-ci @stephentyrone