Skip to content

Enable test case Integers.swift.gyb under x86_64 (and hence Linux x86_64) #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Enable test case Integers.swift.gyb under x86_64 (and hence Linux x86_64) #1904

merged 1 commit into from
Mar 30, 2016

Conversation

practicalswift
Copy link
Contributor

What's in this pull request?

Enable test case Integers.swift.gyb under x86_64 (and hence Linux x86_64).

Resolved bug number: –


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
OS X platform @swift-ci Please test OS X platform
Linux platform @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@tkremenek
Copy link
Member

@swift-ci please test

@practicalswift
Copy link
Contributor Author

@swift-ci Please test again - I believe the build failure is spurious :-)

@gottesmm
Copy link
Contributor

@swift-ci Please test OS X Platform

(Not reviewing, just drive by starting test)

@gottesmm
Copy link
Contributor

@swift-ci Please test OS X Platform

@practicalswift
Copy link
Contributor Author

Is the OS X error real? Everything works fine under Linux and considering that this test was enabled previously under OS X this change shouldn't change the state of things under OS X :-)

@jrose-apple
Copy link
Contributor

Yes, that's real. OS X includes the iOS simulators, and the failure is happening on the i386 simulator. Apparently we can't generate the double-width multiplication there; it's probably something that compiler-rt provides since there's no hardware support.

@practicalswift
Copy link
Contributor Author

@jrose-apple Ah, I see. I've now changed from CPU=i386_or_x86_64 to CPU=x86_64. That should solve the issue? :-)

@practicalswift
Copy link
Contributor Author

@swift-ci Please test :-)

@gribozavr
Copy link
Contributor

@swift-ci Please test and merge

@practicalswift practicalswift changed the title Enable test case Integers.swift.gyb under i386/x86_64 (and hence Linux x86_64) Enable test case Integers.swift.gyb under x86_64 (and hence Linux x86_64) Mar 30, 2016
@swift-ci swift-ci merged commit 9227dfb into swiftlang:master Mar 30, 2016
MaxDesiatov pushed a commit that referenced this pull request Oct 19, 2020
[pull] swiftwasm from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants