[Parse] refactor get/set block parsing #19046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use 'parseAbstractFunctionBody()' for accessors as well. This simplifies the implementation, and makes 'parseAbstractFunctionBody()' the single point of parsing body of every 'AbstructFunctionDecl' types.
Now that, parsing accessor body is done by 'parseAbstractFunctionBody()' which automatically handles delayed parsing by `delayFunctionBodyParsing()`. So we no longer use delayed parsing facilities specific for accessor body.
rintaro
commented
Aug 29, 2018
| Child('Accessor', kind='Syntax', is_optional=True, | ||
| node_choices=[ | ||
| Child('Accessors', kind='AccessorBlock'), | ||
| Child('Getter', kind='CodeBlock')]), |
There was a problem hiding this comment.
This change aligns with the language reference:
https://docs.swift.org/swift-book/ReferenceManual/Declarations.html#//appleref/swift/grammar/variable-declaration
variable-declaration → variable-declaration-head variable-name type-annotation code-block
variable-declaration → variable-declaration-head variable-name type-annotation getter-setter-block
CC: @nkcsgexi
|
@swift-ci Please smoke test |
|
@akyrtzi I'm not sure you are the right person to ask, but are you OK with removing |
|
I'm not super familiar with it but it seems like a nice cleanup to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
parseAbstractFunctionBody()(introduced in #19018) to parse accessor body as well. This simplifies the implementation, and makesparseAbstractFunctionBody()the single point of parsing body of everyAbstractFunctionDecltypes.Also, since
parseAbstractFunctionBody()automatically handles delayed parsing bydelayFunctionBodyParsing(), we no longer use delayed parsing facilities specific for accessor bodies.